Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bug): ensure sticky links are flagged as active in production #341

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Sep 27, 2018

a less insane solution than #334 (to resolve #284)

@coveralls
Copy link

coveralls commented Sep 27, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling a81852e on chore/baseUrl into 2863b5f on master.

@jgravois jgravois changed the title docs(:bug:): ensure sticky links are flagged as active in production docs(bug): ensure sticky links are flagged as active in production Sep 27, 2018
@jgravois
Copy link
Contributor Author

jgravois commented Sep 27, 2018

optional:

acetate server --log=debug --startPath='/arcgis-rest-js' --config docs/acetate.config.js

@jgravois jgravois requested a review from noahmulfinger October 2, 2018 16:37
@jgravois
Copy link
Contributor Author

jgravois commented Oct 5, 2018

@noahmulfinger if you can give me a sanity check on this whenever you can spare the time, i'd be much obliged.

@noahmulfinger
Copy link
Contributor

@jgravois For some reason the index.js file was not being processed correctly with the right base path. I pushed up a change that creates the index.js manually.

Also, though unrelated to this PR, I'm seeing a lot of typescript errors when running npm run docs:serve.

@jgravois
Copy link
Contributor Author

jgravois commented Oct 5, 2018

very cool @noahmulfinger. thank you!

I'm seeing a lot of typescript errors when running npm run docs:serve.

for sure. i've created #347 to track that.

@jgravois jgravois merged commit dd7a5ac into master Oct 5, 2018
@jgravois jgravois deleted the chore/baseUrl branch October 5, 2018 19:40
@jgravois jgravois mentioned this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation pages navigation: highlight currently selected page
3 participants